Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached(ie default) time dimension used instead of requested time dimension for getfeatureinfo #311

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

TAlonglong
Copy link
Contributor

I see using a mapcache - mapserver setup that mapcache sent the wrong time dimension to mapserver for getfeature info.

This PR suggest a fixes for this.

Initially I sent a request to the mailing list https://lists.osgeo.org/pipermail/mapserver-users/2023-April/083104.html , but had a look my self.

This PR replaces mapcache_map_set_cached_dimension with mapcache_map_set_requested_dimension as this sounds more correct and at least gives me the expected result. But as I do this no value for the cached value is set.
I don't know if this is correct behavior.

Please let me know if I need to add additional information.

@jmckenna jmckenna added this to the 1.14.1 release milestone Sep 8, 2023
@jmckenna
Copy link
Member

jmckenna commented Sep 8, 2023

@TAlonglong can you re-base this against main ? I had recently upgraded the CI build system, so hopefully your changes can run without issues now...

@jmckenna
Copy link
Member

thanks @TAlonglong

@jmckenna jmckenna merged commit 885f784 into MapServer:main Sep 29, 2023
7 checks passed
jmckenna pushed a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants