LMDB: minimize transaction duration #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readers do not block anything but tie-up resources; Writers block other writers and thus it's good idea to keep them short.
As MapCache LMDB uses single entry per key, there is no need to pass data to mdb_del call.
jmckenna
pushed a commit
that referenced
this pull request
Aug 2, 2024
* LMDB: minimize transaction duration Readers do not block anything but tie-up resources; Writers block other writers and thus it's good idea to keep them short. * LMDB: do not pass data variable when deleting tiles As MapCache LMDB uses single entry per key, there is no need to pass data to mdb_del call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor LMDB cache optimization. The less we keep transaction running, the better it is. Reader transactions tie-up resources if concurrent writes are made. Writing transactions block other writing transactions and thus slows down overall writes. Thus shorter transactions should improve overall throughput and reduce resource use.