Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http basic authorization option to http requests (related to #283) #328

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Add http basic authorization option to http requests (related to #283) #328

merged 4 commits into from
Jan 25, 2024

Conversation

marisn
Copy link
Contributor

@marisn marisn commented Jan 15, 2024

This PR adds capability to access password protected WMS sources.

jratike80
jratike80 reviewed Jan 15, 2024
View reviewed changes
lib/http.c Show resolved Hide resolved
@marisn marisn marked this pull request as draft January 15, 2024 14:45
@marisn
Copy link
Contributor Author

marisn commented Jan 15, 2024

Apparently apr_encode is available only starting from APR 1.7.0. Needs cmake checks.

@tbonfort
Copy link
Member

Apparently apr_encode is available only starting from APR 1.7.0. Needs cmake checks.

could the base64_encode function provided in util.c be used instead of apr_encode ?

@marisn
Copy link
Contributor Author

marisn commented Jan 15, 2024

could the base64_encode function provided in util.c be used instead of apr_encode ?

Yes it can. As I found a function in APR, I even didn't think to grep local source. My bad.

@marisn marisn marked this pull request as ready for review January 15, 2024 17:49
@marisn marisn requested a review from jratike80 January 15, 2024 17:49
@jratike80
Copy link

Sorry, but I am not competent for reviewing the code. I am just a user with some experience on Mapserver.

@marisn
Copy link
Contributor Author

marisn commented Jan 16, 2024

Sorry, but I am not competent for reviewing the code. I am just a user with some experience on Mapserver.

Thanks for valuable feedback anyway. I fixed the typo and checked that your use case should work. Please mark conversation as resolved. No need to approve the PR.

@marisn marisn mentioned this pull request Jan 16, 2024
Merged
@jmckenna jmckenna added this to the 1.14.1 release milestone Jan 25, 2024
@jmckenna
Copy link
Member

thanks @marisn !

@jmckenna jmckenna merged commit 2f3e0ad into MapServer:main Jan 25, 2024
7 checks passed
jmckenna pushed a commit that referenced this pull request Aug 2, 2024
@marisn @jmckenna
Add http basic authorization option to http requests (related to #283) (
c01c6d3 
#328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbonfort tbonfort tbonfort approved these changes

@jratike80 jratike80 Awaiting requested review from jratike80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.1 release
Development

Successfully merging this pull request may close these issues.
4 participants
@marisn @tbonfort @jratike80 @jmckenna