-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration with Teamcity status message #611
Conversation
Please provide more details about this feature, also we will need to update docs after you merge it. |
id("org.jetbrains.dokka") | ||
} | ||
|
||
Deployment.initialize(project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're adding a new module - it should be published as well. I don't think we need to create a separate jar for this though
@@ -73,7 +75,8 @@ data class Configuration private constructor( | |||
"debug" to debug.toString(), | |||
"screenRecordingPolicy" to screenRecordingPolicy.toString(), | |||
"vendorConfiguration" to vendorConfiguration.toString(), | |||
"deviceInitializationTimeoutMillis" to deviceInitializationTimeoutMillis.toString() | |||
"deviceInitializationTimeoutMillis" to deviceInitializationTimeoutMillis.toString(), | |||
"buildSystem" to buildSystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should be a separate configuration class, e.g. BuildSystemConfiguration -> TeamCityConfiguration instead of just an enum. Otherwise we don't make it extensible in the future with parameters to the build system (e.g. ignore X, print more, etc)
aa111b3
to
949f101
Compare
949f101
to
b6ad034
Compare
Codecov Report
@@ Coverage Diff @@
## develop #611 +/- ##
=============================================
- Coverage 64.98% 62.92% -2.07%
- Complexity 696 705 +9
=============================================
Files 168 174 +6
Lines 3336 3517 +181
Branches 565 588 +23
=============================================
+ Hits 2168 2213 +45
- Misses 881 1008 +127
- Partials 287 296 +9
Continue to review full report at Codecov.
|
See: #964 |
No description provided.