Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ MiniMessage support in Text #57

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

pjesek
Copy link
Contributor

@pjesek pjesek commented May 29, 2024

No description provided.

* @return MiniMessage deserialized component.
*/
public @NotNull Text mini() {
MiniMessage mm = MiniMessage.miniMessage();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks a cool addition, can we make it so instead make like a static function Text.mini("etc");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to make it static, done

@pjesek pjesek requested a review from MarcusSlover May 29, 2024 18:45
Copy link
Owner

@MarcusSlover MarcusSlover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarcusSlover MarcusSlover merged commit feb0292 into MarcusSlover:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants