Remove pandas to make build working again #589
Conversation
rconweb/api/models.py
Outdated
| @@ -225,7 +225,6 @@ class Meta: | |||
| "Can view the amount of time left in the round", | |||
| ), | |||
| ("can_view_server_name", "Can view the server name"), | |||
| ("can_view_server_stats", "Can view the get_server_stats endpoint"), | |||
There was a problem hiding this comment.
I don't know enough about the permissions in Django tbh :( Do I need to do anything else here to make this change flawless? Like, will the permission automatically be removed from the groups and users that own them right now?
There was a problem hiding this comment.
I'd probably just leave the permissions in case we want to use them later, they don't really hurt anything.
But this models.py file needs to be updated and then we'd need to modify migration 2 or 3 (I forget) which creates the default groups
There was a problem hiding this comment.
I'd probably just leave the permissions in case we want to use them later, they don't really hurt anything.
I don't think that this would be a very good thing. People might misinterpret the permission, especially given when it does not do anything :/
But this models.py file needs to be updated and then we'd need to modify migration 2 or 3 (I forget) which creates the default groups
👍
|
This got resolved on |
|
I mean, pandas is a big dependency, not sure how useful it is, if we don't actually use it 😅 |
|
I agree I think we can remove this stuff; has merge conflicts now though 🤔 |
|
I'll look into them after my event I play today 👍 |
Upgrading to the latest version of pandas would've worked, too. However, the server stats API is not finnisshed, not run on regular users workloads (except they intentionally enabled it) and was most likely not finished at all. No need in keeping it for much longer.
FlorianSW
force-pushed
the
maint/pandas
branch
from
68142a9
to
840efb1
Compare
|
@cemathey rebased the PR, could you take another look? ❤️ |
Upgrading to the latest version of pandas would've worked, too. However, the server stats API is not finnisshed, not run on regular users workloads (except they intentionally enabled it) and was most likely not finished at all. No need in keeping it for much longer.