do not use mixed as team side for player with marginal kills/deaths w… #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the "other" side
Dorfieeee
reviewed
Dec 29, 2024
tests/test_player_stats.py
Outdated
| 'MG42': 1, | ||
| 'SATCHEL': 1, | ||
| 'BOMBING RUN': 1, | ||
| # this is a teamkill or a wrongly attributed kill and should not result in a MIXED team confidence |
There was a problem hiding this comment.
it's not a teamkill nor wrongly attributed in my opinion. the player was probably killed by an explosion of the Sherman which must have been caused by any kind of explosive used by the opposite team eg. artillery, tank, satchel, at gun, ...
There was a problem hiding this comment.
let me add that as additional info to the comment 👍
Signed-off-by: Florian <[email protected]>
LordofAgents
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith the "other" side