remove weapons data from frontend #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not used anywhere, yet. And if the frontend needs a list of all the weapons, it should request that list from the backend in the context of where the data is needed (e.g. for stats of a match, etc). There is no need to ship a lot of data in the bundle just because the data might be worthful in the future. Secondly, the weapon data is already present in the backend, with the information that was previously covered by the data in the frontend. Maintaining both lists is an overhead which we can reduce.
|
I did request translations from T17; haven't heard back but they are on their holiday break still. |
|
we could add translations to the backend or frontend, I do not care, however, for now there are none, so this data should be removed so we do not need to maintain it :D |
cemathey
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not used anywhere, yet.
And if the frontend needs a list of all the weapons, it should request that list from the backend in the context of where the data is needed (e.g. for stats of a match, etc). There is no need to ship a lot of data in the bundle just because the data might be worthful in the future.
Secondly, the weapon data is already present in the backend, with the information that was previously covered by the data in the frontend. Maintaining both lists is an overhead which we can reduce.