update BABYSTEP_MULTIPLICATOR_Z assert #27471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BABYSTEP_MULTIPLICATOR_Z has two modes
If BABYSTEP_MILLIMETER_UNITS is defined the value must be less or equal to 0.1
else (ie step mode) the value needs to be a non zero integer,
BABYSTEP_MILLIMETER_UNITS has a static assert to check if the value is valid.
step mode did not.
This lead to #27438
Where the user set
Causing baby stepping to not work.
I updated the description of the original assert to make it clear that BABYSTEP_MILLIMETER_UNITS was set.
I added a second assert to test for integers values for step mode.
Requirements
#define BABYSTEPPING
#define BABYSTEP_MILLIMETER_UNITS or //#define BABYSTEP_MILLIMETER_UNITS
#define BABYSTEP_MULTIPLICATOR_Z {assorted values}
Benefits
Less confused users
Related Issues