Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update BABYSTEP_MULTIPLICATOR_Z assert #27471

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Oct 11, 2024

Description

BABYSTEP_MULTIPLICATOR_Z has two modes
If BABYSTEP_MILLIMETER_UNITS is defined the value must be less or equal to 0.1
else (ie step mode) the value needs to be a non zero integer,

BABYSTEP_MILLIMETER_UNITS has a static assert to check if the value is valid.
step mode did not.

This lead to #27438
Where the user set

//#define BABYSTEP_MILLIMETER_UNITS       // Specify BABYSTEP_MULTIPLICATOR_(XY|Z) in mm instead of micro-steps
  #define BABYSTEP_MULTIPLICATOR_Z  0.01       // (steps or mm) Steps or millimeter distance for each Z babystep

Causing baby stepping to not work.

I updated the description of the original assert to make it clear that BABYSTEP_MILLIMETER_UNITS was set.
I added a second assert to test for integers values for step mode.

Requirements

#define BABYSTEPPING
#define BABYSTEP_MILLIMETER_UNITS or //#define BABYSTEP_MILLIMETER_UNITS
#define BABYSTEP_MULTIPLICATOR_Z {assorted values}

Benefits

Less confused users

Related Issues

  • [BUG] Babystepping not working on BTT SKR Mini E3 V3.0 #27438
  • @ellensp ellensp added this to the Version 2.1.3 milestone Oct 14, 2024
    @thinkyhead thinkyhead merged commit b9f7d72 into MarlinFirmware:bugfix-2.1.x Oct 20, 2024
    63 checks passed
    @ellensp ellensp deleted the add-BABYSTEP_MULTIPLICATOR_Z-check branch October 20, 2024 03:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants