Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #96

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Error handling #96

merged 2 commits into from
Jan 17, 2024

Conversation

SumitNalavade
Copy link
Member

Removes popups for certain requests that may fail due to minor errors such as a dropped network connection, but preserves notifications if something major fails such as the initial api requests on index.tsx.

These requests are needed for all the subsequent functionality for the app and only run once, so they shouldn't be ignored

Copy link
Member

@bwees bwees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwees bwees merged commit f8d5247 into main Jan 17, 2024
1 check passed
@bwees bwees deleted the Error-Handling branch January 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants