This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Fix Lag EngineMassiveCoreCollTick.java #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes persistent lag issue that'll cause up to 80% TPS loss. Save interval is now every 500 ticks instead of every 1 tick. This'll save server performance in the long run and prevent lag issues with larger Factions servers. https://gyazo.com/de62ac3758bd3e4409695e2b162f620f Timings report with interval set to 1 https://gyazo.com/5e4cc3128c20fa350a09eec0bf953d6a Timings report with new interval Huge performance increase.
|
500 ticks was just the sweet spot I found after fidgeting, as it's not too quick but not too slow so MassiveCore plugins won't experience much data loss if it crashes within those 500 ticks. You may experiment with the value, however 500 works perfectly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes persistent lag issue that'll cause up to 80% TPS loss.
Save interval is now every 500 ticks instead of every 1 tick. This'll save server performance in the long run and prevent lag issues with larger Factions servers.
https://gyazo.com/de62ac3758bd3e4409695e2b162f620f Timings report with interval set to 1
https://gyazo.com/5e4cc3128c20fa350a09eec0bf953d6a Timings report with new interval
Huge performance increase.