Cleanup gdscript examples #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now obsolete, replaced by `Project_Example/dependancy/TileMap.gd`.
'Unneeded comments' here are e.g. ```gdscript # Called when the node enters the scene tree for the first time. func _ready(): ```
This uses the following conventions: * Items are grouped by 'kind' (aka `const`, `var`, `func`...). Each group is separated by a newline, functions are separated by **two** newlines from the rest and eachother * `gdformat --line-length=88` is used for formatting (88 seemed like a good length, and fits perfectly in the godot editor on my machine so 🤷) As an aside, godot's "line lenght guideline column" option was very helpful there 🙂 * Comments start with a space after `#`, and usually with an Uppercase. They also don't cross the 88 line length limit.
|
I guess that if you have very strong opinions on code style, the 'Use consistent style in gdscript' commit might be controversial 😅 |
|
thank you! Sorry for the delay, I'm in middle of exam period currently, so time is scarce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the gdscript examples more readable.
This addresses some of the comments made in #95.
Also fixes #100