Add DialogHost.DialogCardStyle DP to allow control from calling code #3459
+85
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| IVisualElement<DialogHost> dialogHost = await grid.GetElement<DialogHost>("DialogHost"); | ||
| IVisualElement<Card> nestedCard = await dialogHost.GetElement<Card>("PART_PopupContentElement"); | ||
|
|
||
| // TODO: Assert the style on the nested card matches what is set in DialogHost.DialogCardStyle |
There was a problem hiding this comment.
@Keboo this is where I hit a road block. Any help would be appreciated 🙏
Rather than asserting on the style, it asserts on a set value from the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3430
UPDATE
The outstanding issue we have with this PR is the fact that calling code can effectively set a (card) style, but several properties from that style will be ignored because they are "passed-in/hardcoded" in the
PART_PopupContentElementelement in theDialogHoststyle.This PR allows the calling code to control the style of the nested
Cardin theDialogHost. DefaultBackgroundproperty is now set directly on the card, and the trigger to fall back to the default background is moved to theControlTemplate.Triggerscollection.@Keboo I started on writing some UI test to verify this gets passed down, but I hit a roadblock around getting the
Style(or perhaps just the name of the style) out of anIVisualElement, any hints you can provide?