Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Seal: Drop chain while feeding data to builder (#482) #11

Merged
merged 1 commit into from
May 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/trace/implementations/merge_batcher_col.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use crate::consolidation::consolidate_updates;
use std::cmp::Ordering;
use timely::communication::message::RefOrMut;
use timely::container::columnation::{Columnation, TimelyStack};

Check failure on line 6 in src/trace/implementations/merge_batcher_col.rs

View workflow job for this annotation

GitHub Actions / test mdBook

failed to resolve: could not find `container` in `timely`

Check failure on line 6 in src/trace/implementations/merge_batcher_col.rs

View workflow job for this annotation

GitHub Actions / cargo test on ubuntu, rust stable

failed to resolve: could not find `container` in `timely`

Check failure on line 6 in src/trace/implementations/merge_batcher_col.rs

View workflow job for this annotation

GitHub Actions / cargo test on ubuntu, rust 1.72

failed to resolve: could not find `container` in `timely`

Check failure on line 6 in src/trace/implementations/merge_batcher_col.rs

View workflow job for this annotation

GitHub Actions / cargo test on macos, rust stable

failed to resolve: could not find `container` in `timely`

Check failure on line 6 in src/trace/implementations/merge_batcher_col.rs

View workflow job for this annotation

GitHub Actions / cargo test on macos, rust 1.72

failed to resolve: could not find `container` in `timely`
use timely::progress::frontier::{Antichain, AntichainRef};
use timely::{Container, Data, PartialOrder};

Expand Down Expand Up @@ -291,8 +291,10 @@
}
let mut builder = B::with_capacity(keys, vals, upds);

for datum in chain.iter().flat_map(|ts| ts.iter()) {
builder.copy(datum);
for chunk in chain.drain(..) {
for datum in chunk.iter() {
builder.copy(datum);
}
}

builder.done(lower.to_owned(), upper.to_owned(), since.to_owned())
Expand Down
Loading