Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: round probe timestamps to the probe interval #31072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

storage: round probe timestamps to the probe interval #31072

wants to merge 1 commit into from
+203 −16

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Jan 16, 2025 •
edited
Loading

This PR ensures that probe timestamps, and therefore timestamps used for minting new bindings, are rounded down to the probe interval (typically 1s). This is to reduce the amount of distinct timestamps flowing through a dataflow joining multiple sources. Each distinct timestamp induces some amount of overhead, so forcing the timestamps of individual sources to the same values is more efficient.

Motivation

  • This PR adds a known-desirable feature.

Closes https://github.com/MaterializeInc/database-issues/issues/8885

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje teskje marked this pull request as ready for review January 16, 2025 17:39
@teskje teskje requested a review from a team as a code owner January 16, 2025 17:39
@teskje teskje requested a review from petrosagg January 16, 2025 17:39
@teskje teskje force-pushed the probe-round-timestamps branch from 1f74863 to cd4f574 Compare January 17, 2025 09:54
@teskje
storage: round probe timestamps to the probe interval
c5a5c10 
This commit ensures that probe timestamps, and therefore timestamps used
for minting new bindings, are rounded down to the probe interval
(typically 1s). This is to reduce the amount of distinct timestamps
flowing through a dataflow joining multiple sources. Each distinct
timestamp induces some amount of overhead, so forcing the timestamps of
individual sources to the same values is more efficient.
@teskje teskje force-pushed the probe-round-timestamps branch from cd4f574 to c5a5c10 Compare January 17, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrosagg petrosagg Awaiting requested review from petrosagg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teskje