Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: tidy up bin/bazel invocations a bit #31106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ParkMyCar
Copy link
Member

Wrap the call to subprocess in a try-catch so when a Bazel build fails or is canceled we don't print the Python backtrace.

Motivation

Makes bin/bazel a little nicer.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested review from def- and jkosh44 January 18, 2025 02:39
@ParkMyCar ParkMyCar force-pushed the bazel/tidy-up-command branch from 7166291 to a8ab85b Compare January 18, 2025 02:41
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of side effects does it have that we continue running at this point? The command will also return 0 (success) now even when a failure happened. I'd suggest at least passing the error through and returning 1 from main, or alternatively catching the exception in main and returning the error there, without ever printing the python backtrace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants