Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Attribute Name Leaking #353

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Prevent Attribute Name Leaking #353

merged 4 commits into from
Nov 14, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Nov 9, 2023

Fixes #352

Prevent leaking of top level database_name and schema_name resource attributes into other references that have a database and schema names. Instead of inheriting these (if not set), they will use the standard defaults for schema (public) and database (materialize or the env variable).

@dehume dehume added bug Something isn't working breaking change Will cause a breaking change in the next release labels Nov 9, 2023
@dehume dehume requested a review from bobbyiliev as a code owner November 9, 2023 17:27
benesch
benesch reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix makes a lot of sense to me. This may be enough of a breaking change that it needs to be a 0.3.0 though!

Not approving as I didn't look in detail at the code.

pkg/materialize/identifiers.go Show resolved Hide resolved
bobbyiliev
bobbyiliev approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for working on this and for introducing the fix so quickly!

@dehume dehume merged commit 15aea38 into main Nov 14, 2023
4 checks passed
@dehume dehume deleted the Prevent-Name-Leaking branch November 14, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch left review comments

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
breaking change Will cause a breaking change in the next release bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leaking database_name and schema_name in Resources
3 participants
@dehume @benesch @bobbyiliev