Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create sink with key statemets #358

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Fix create sink with key statemets #358

merged 5 commits into from
Nov 14, 2023

Conversation

bobbyiliev
Copy link
Contributor

In the CREATE SINK statements the topic should be defined before the key, otherwise you would end up with this error:

Error: ERROR: Expected end of statement, found left parenthesis (SQLSTATE 42601)

@bobbyiliev bobbyiliev requested a review from dehume as a code owner November 14, 2023 11:01
@bobbyiliev bobbyiliev merged commit 2bf8ed7 into main Nov 14, 2023
5 checks passed
@bobbyiliev bobbyiliev deleted the bugfix-sink-keys branch November 14, 2023 13:12
@dehume dehume added the bug Something isn't working label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehume dehume dehume approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbyiliev @dehume