Add public psuedo role to resource grant #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
requested review from
SangJunBak,
benesch and
a team
and removed request for
a team
bobbyiliev
commented
Mar 27, 2024
Comment on lines
133
to
140
| func (b *MaterializeRole) QualifiedName() string { | ||
| // If role name is PUBLIC, it should not be quoted as it is a pseudo-role | ||
| if b.name == "PUBLIC" { | ||
| return b.name | ||
| } | ||
| return QualifiedName(b.name) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is essentially the main change, the rest is just tests.
SangJunBak
approved these changes
Mar 27, 2024
| pp := `WHERE mz_clusters.id = 'u1'` | ||
| testhelpers.MockClusterScan(mock, pp) | ||
|
|
||
| if err := grantClusterCreate(context.TODO(), d, db); err != nil { |
There was a problem hiding this comment.
Out of curiosity, what does context.TODO() do here?
There was a problem hiding this comment.
Thanks Jun 🙌
The context.TODO() returns a non-nil, empty Context. It is just used as a placeholder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like that we used to be generating the following:
This PR checks if the role is
PUBLICand if so, it does not quote it.