Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Kafka Source: Add VALUE DECODING ERRORS arg #586

Merged
merged 4 commits into from
Jun 30, 2024

Conversation

bobbyiliev
Copy link
Contributor

@bobbyiliev bobbyiliev commented Jun 28, 2024

Fixes #585

Tests will still be failing until the new release is cut and the new Docker image is available.

@bobbyiliev bobbyiliev requested a review from a team as a code owner June 28, 2024 09:04
@bobbyiliev bobbyiliev requested review from RobinClowers and removed request for a team June 28, 2024 09:04
Comment on lines +397 to +402
envelope {
upsert = true
upsert_options {
value_decoding_errors = "INLINE"
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the new upsert options attribute will be used

@bobbyiliev bobbyiliev requested a review from morsapaes June 28, 2024 09:06
@bobbyiliev bobbyiliev changed the title Resource Kafka Source: Add VALUE DECODING ERRORSarg Resource Kafka Source: Add VALUE DECODING ERRORS arg Jun 28, 2024
@morsapaes morsapaes requested a review from rjobanp June 28, 2024 11:14
@bobbyiliev bobbyiliev merged commit 2bd8741 into main Jun 30, 2024
6 checks passed
@bobbyiliev bobbyiliev deleted the add-value-decoding-errors-kafka-attr branch June 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support VALUE DECODING ERRORS option in the Kafka source resource
2 participants