Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL source tests for ignore columns #616

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

bobbyiliev
Copy link
Contributor

Fixes #491

@bobbyiliev bobbyiliev requested a review from a team as a code owner July 22, 2024 11:48
@bobbyiliev bobbyiliev requested review from SangJunBak and removed request for a team July 22, 2024 11:48
-- TODO: Disable until https://github.com/MaterializeInc/materialize/issues/24952 is resolved
-- updated_at TIMESTAMP NOT NULL
banned BOOLEAN,
updated_at TIMESTAMP NOT NULL
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now supported, so removing the comments here

CREATE TABLE IF NOT EXISTS mysql_table4
(
id INT AUTO_INCREMENT PRIMARY KEY,
status ENUM('active', 'inactive', 'deleted') NOT NULL DEFAULT 'active'
Copy link
Contributor Author

@bobbyiliev bobbyiliev Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a table with ENUM type to test the text_columns attr

Copy link

@SangJunBak SangJunBak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobbyiliev bobbyiliev merged commit cd11834 into main Jul 24, 2024
6 checks passed
@bobbyiliev bobbyiliev deleted the mysql-source-columns-tests branch July 24, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL Source: Add acceptance tests for IGNORE COLUMNS and TEXT COLUMNS
2 participants