Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap-builtin-analytics-cluster-replica-size #671

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

bobbyiliev
Copy link
Contributor

Adding --bootstrap-builtin-analytics-cluster-replica-size=3xsmall in order to fix the following panic with the latest materialzied image:

 Connection could not be recycled: Connection closed    
thread 'main' panicked at src/environmentd/src/bin/environmentd/main.rs:635:9:
environmentd: fatal: unknown cluster replica size '1'
   8: rust_begin_unwind
             at ./rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/std/src/panicking.rs:652:5
   9: core::panicking::panic_fmt
             at ./rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/panicking.rs:72:14
  10: environmentd::main
             at src/environmentd/src/bin/environmentd/main.rs:635:9
  11: <fn() as core::ops::function::FnOnce<()>>::call_once
             at ./rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@bobbyiliev bobbyiliev requested a review from a team as a code owner November 17, 2024 12:06
@bobbyiliev bobbyiliev requested review from SangJunBak and def- and removed request for a team November 17, 2024 12:06
@bobbyiliev bobbyiliev changed the title Add bootstrap-builtin-analytics-cluster-replica-siz Add bootstrap-builtin-analytics-cluster-replica-size Nov 17, 2024
@@ -1,6 +1,4 @@
---
version: "3.9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deprecated and no longer needed in compose files

Comment on lines -170 to +171
if b.disk {
// Only add DISK to the quiery builder if it's enabled AND size doesn't end in either "cc" or "C"
if b.disk && !strings.HasSuffix(b.size, "cc") && !strings.HasSuffix(b.size, "C") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was working fine in the past as the disk option was silently ignored in Materialize for cc and C clusters. However this no longer seems to be the case so we need to explicitly skip it in the query builder.

@bobbyiliev bobbyiliev merged commit 59cbace into main Nov 18, 2024
4 checks passed
@bobbyiliev bobbyiliev deleted the bootstrap-builtin-analytics-cluster-replica-size branch November 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants