-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap-builtin-analytics-cluster-replica-size #671
Add bootstrap-builtin-analytics-cluster-replica-size #671
Conversation
@@ -1,6 +1,4 @@ | |||
--- | |||
version: "3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deprecated and no longer needed in compose files
if b.disk { | ||
// Only add DISK to the quiery builder if it's enabled AND size doesn't end in either "cc" or "C" | ||
if b.disk && !strings.HasSuffix(b.size, "cc") && !strings.HasSuffix(b.size, "C") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was working fine in the past as the disk option was silently ignored in Materialize for cc and C clusters. However this no longer seems to be the case so we need to explicitly skip it in the query builder.
Adding
--bootstrap-builtin-analytics-cluster-replica-size=3xsmall
in order to fix the following panic with the latest materialzied image: