lsp: single client + sequential requests #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
approved these changes
Nov 3, 2023
|
I like this solution! It's pretty much 1:1 with how TablePlus does it too~ Screen.Recording.2023-11-03.at.11.28.08.AM.mov |
|
@SangJunBak Yes! I checked exactly in their client to make sure the behavior was similar to other clients. The only difference is that we check the syntax before. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #113.
After the user triggers the SQL command, the extension will parse the SQL code, split the SQL code into individual statements, and run each statement independently. If one statement fails, the process ends.
All the statements written by the user run in a single SQL client session. Therefore, the client behaves like a SQL shell session. If the user runs
BEGIN;in one file, they can issueCOMMIT;orROLLBACK;from any other file.Tagging @chuck-alt-delete and @SangJunBak to make sure this behavior conforms to expectations.