Propose TLS trait and a builder for TlsConnector #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisrk
force-pushed
the
feature/tls-options
branch
2 times, most recently
from
bc84790
to
9fdac6f
Compare
keisrk
force-pushed
the
feature/tls-options
branch
from
9fdac6f
to
6edb845
Compare
keisrk
force-pushed
the
feature/tls-options
branch
2 times, most recently
from
a97b0f1
to
a7d9f12
Compare
What a user shoud provide would be 1. TlsConnector type specific to his/her driver implementation and 2. TryFrom<TlsConfig> for TlsConnector and implement Tls trait for the his/her TcpStack in terms of the TlsConnector.
keisrk
force-pushed
the
feature/tls-options
branch
from
a7d9f12
to
a5de624
Compare
unizippro
reviewed
Jan 5, 2021
| /// The TLS 1.1 protocol. | ||
| Tlsv11 = 2, | ||
| /// The TLS 1.2 protocol. | ||
| Tlsv12 = 3, |
|
Any chance this could still move forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also the discussion in original repo.
The idea is to bring to embedded world the same (or similar) set of APIs you can find in rust-native-tls.