-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
51 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,67 @@ | ||
diff --git zetasql/analyzer/BUILD zetasql/analyzer/BUILD | ||
index 91c73c6..57e5609 100644 | ||
--- zetasql/analyzer/BUILD | ||
+++ zetasql/analyzer/BUILD | ||
@@ -18,7 +18,7 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library") | ||
load(":builddefs.bzl", "gen_analyzer_test") | ||
|
||
package( | ||
- default_visibility = ["//zetasql/base:zetasql_implementation"], | ||
+ default_visibility = ["//visibility:public"], | ||
) | ||
|
||
filegroup( | ||
diff --git zetasql/base/BUILD zetasql/base/BUILD | ||
index 75c8e3e..7874e07 100644 | ||
--- zetasql/base/BUILD | ||
+++ zetasql/base/BUILD | ||
@@ -17,7 +17,7 @@ | ||
licenses(["notice"]) # Apache v2.0 | ||
|
||
package( | ||
- default_visibility = [":zetasql_implementation"], | ||
+ default_visibility = ["//visibility:public"], | ||
) | ||
|
||
package_group( | ||
diff --git zetasql/parser/BUILD zetasql/parser/BUILD | ||
index 5c3c636..5404163 100644 | ||
--- zetasql/parser/BUILD | ||
+++ zetasql/parser/BUILD | ||
@@ -20,7 +20,7 @@ load("//bazel:bison.bzl", "genyacc") | ||
load("//bazel:flex.bzl", "genlex") | ||
|
||
package( | ||
- default_visibility = ["//zetasql/base:zetasql_implementation"], | ||
+ default_visibility = ["//visibility:public"], | ||
) | ||
|
||
genrule( | ||
|
||
--- zetasql/public/simple_catalog.h | ||
+++ zetasql/public/simple_catalog.h | ||
@@ -55,6 +55,11 @@ class SimpleTableProto; | ||
// | ||
// This class is thread-safe. | ||
class SimpleCatalog : public EnumerableCatalog { | ||
+ friend void dropOwnedTable(SimpleCatalog* catalog, const std::string& name); | ||
+ friend void dropOwnedTableIfExists(SimpleCatalog* catalog, const std::string& name); | ||
+ friend void dropOwnedFunction(SimpleCatalog* catalog, const std::string& full_name_without_group); | ||
+ | ||
+ | ||
public: | ||
// Construct a Catalog with catalog name <name>. | ||
// | ||
|
||
diff --git zetasql/public/sql_formatter.cc zetasql/public/sql_formatter.cc | ||
index 26e52ed..28e8928 100644 | ||
--- zetasql/public/sql_formatter.cc | ||
+++ zetasql/public/sql_formatter.cc | ||
@@ -72,6 +72,7 @@ absl::Status FormatSql(const std::string& sql, std::string* formatted_sql) { | ||
std::vector<ParseToken> parse_tokens; | ||
ParseTokenOptions options; | ||
options.stop_at_end_of_statement = true; | ||
+ options.include_comments = true; | ||
const int statement_start = location.byte_position(); | ||
const absl::Status token_status = | ||
GetParseTokens(options, &location, &parse_tokens); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Analyzing "samples/sample-ci/sample/create_datawarehouse3.sql" | ||
ERROR: INVALID_ARGUMENT: Table not found: `bigquery-public-data.samples.gsod` [at samples/sample-ci/sample/create_datawarehouse3.sql:5:3] | ||
catalog: | ||
dataset.main | ||
tablename2 | ||
dataset.main | ||
tablename1 |