Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result analysis reporting #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Nov 27, 2023

Change the place where we run result analysis. The logic is now shared between PR testing and release testing, so there's less repeated code. Result analysis is now covered by the same reporting of results on GitHub or over email, so this fixes #120.

Also tweak the staging of result analysis to fix #127.

CI runs on ec59ea0:

  • pr-head, development, good: internal
  • pr-merge, development, good: internal
  • pr-head, development, test failures: internal
  • pr-head, development, tests pass but outcome analysis fails: TODO
  • release, development, good: OpenCI
  • release, development, test failures: OpenCI
  • release, development, tests pass but outcome analysis fails: TODO

@gilles-peskine-arm gilles-peskine-arm added bug Something isn't working needs: ci size-s Estimated task size: small (~2d) priority-medium needs: work labels Nov 27, 2023
@gilles-peskine-arm gilles-peskine-arm changed the title Dev/gilles peskine arm/result analysis reporting Fix result analysis reporting Nov 28, 2023
No behavior change.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm force-pushed the dev/gilles-peskine-arm/result-analysis-reporting branch 3 times, most recently from 9bc7fb5 to 25a4dea Compare May 23, 2024 09:24
For visibility on BlueOcean, ensure that the unstash steps are in
their own stage. This way they don't hide other steps despite
BlueOcean truncating the step list at 100 elements.

Nest stages { parallel { stages {} } } even though there is a single
element in the parallel dispatch, because BlueOcean doesn't separate
nested sequential stages inside of sequential staging.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm force-pushed the dev/gilles-peskine-arm/result-analysis-reporting branch from 25a4dea to 0493b31 Compare May 23, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs: ci needs: work priority-medium size-s Estimated task size: small (~2d)
Projects
None yet
1 participant