Use the MSVC versions supported by each branch #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.28 PRs test MSVC 2013, and nightlies test 2013, 2015 and 2017. development PRs and nightlies only test MSVC 2017. Signed-off-by: Bence Szépkúti <[email protected]>
bensze01
added
enhancement
| } else { | ||
| vs_builds = ['2013', '2017'] | ||
| if (env.MBED_TLS_BRANCH == 'mbedtls-2.28') { |
There was a problem hiding this comment.
How is MBED_TLS_BRANCH determined?
I fear that this approach will break if we make bugfix branches. Does it even work with security fixes that target mbedtls-2.28-restricted?
What we've done in the past was to read a file in the repository and base the testing on that. For example, at one point we had C89 branches tested with VS2010 and C99 branches tested with VS2013. See d4272ac and 5b1eb91.
By the way, that second commit suggests that we might need to change windows_testing.py too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.28 PRs test MSVC 2013, and nightlies test 2013, 2015 and 2017.
development PRs and nightlies only test MSVC 2017.