Refactor scripts to use config.py instead of config.pl #178
Conversation
resources/windows/windows_testing.py
Outdated
| )) | ||
| try: | ||
| enable_output = subprocess.run( | ||
| [self.perl_command, self.config_pl_location, "full"], | ||
| [self.config_py_location, "full"], |
There was a problem hiding this comment.
Don't we need to invoke the Python interpreter explicitly? Windows doesn't understand shebang lines, and I don't know if our CI systems are configured to have *.py files executable via python.exe.
There was a problem hiding this comment.
I have resolved this now, I still need to test it however Docker on MacOS is proving to be a bit troublesome.
| self.selftest_exe = "selftest.exe" | ||
| self.mingw_command = "mingw32-make" | ||
| self.git_command = "git" | ||
| self.perl_command = "perl" |
There was a problem hiding this comment.
Historical note: we need this script to run with all maintained branches, not just the latest. The last supported branch of Mbed TLS that had only config.pl and not config.py was 2.16. The oldest still-supported branch is 2.28, and it has config.py. Therefore it's ok to remove support for branches that don't have config.py.
This commit refactors Windows testing scripts to use config.py instead of config.pl because config.pl is being removed from the Mbed TLS repository. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
force-pushed
the
refactor-config-pl-config-py-main
branch
from
5a1c2d3
to
8315fe3
Compare
|
I haven't been able to fully test this due to various docker issues with MacOS. Would anyone be able to run this on their docker setup to ensure it passes successfully? |
This commit refactors Windows testing scripts to use config.py instead of config.pl because config.pl is being removed from the Mbed TLS repository.
This is required for issue in Mbed TLS: 9663
This is required for pull request in Mbed TLS: 9666