Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_particle->_index must be 1-based #35

Closed
g5t opened this issue Dec 9, 2023 · 1 comment · Fixed by #36
Closed

_particle->_index must be 1-based #35

g5t opened this issue Dec 9, 2023 · 1 comment · Fixed by #36

Comments

@g5t
Copy link
Collaborator

g5t commented Dec 9, 2023

To allow for #30 the particle's component-position index must be a 1-based index. The change to 0-based indexing must be undone to use the upstream runtime files due to the initialization of _particle->_index = 1 in mcsetstate in both mcstas-r.c and mcxtrace-r.c
@g5t
Copy link
Collaborator Author

g5t commented Dec 9, 2023

This is only a problem in raytrace_all_funnel, which was never tested in mccode-antlr.
The 'normal' raytrace function was switched back to 1-based indexing at some point in the past.

@g5t g5t linked a pull request Dec 9, 2023 that will close this issue
[Fix] generated runtime errors #36
Merged
@g5t g5t closed this as completed in #36 Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] generated runtime errors McStasMcXtrace/mccode-antlr
1 participant
@g5t