[Fix] generated runtime errors #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parts of the generated runtime were not handled correctly due to
oversights and lack of testing. The OpenACC-only funnel version of the
raytracer did not index component instances correctly and always
skipped the first component. The jump and split logic in the main
raytrace included Expr output which did not check for
instrument-parameter-ness via the {:p} format specification.
- Indexing and formatting errors are fixed. Tests are added to exercise
the runtime logic.
Additionally, the operators "%", "<<" and ">>" are now supported in
Expr objects (and parse from Instr/Comp files).
- The runtime should now be more correct without any negative side
effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, the operators
%,<<and>>are now supported inExprobjects (and parse fromInstr/Compfiles)