Fix component placement bug #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing `__version__` from `mccode_antlr` only works if it is installed, otherwise the `__init__` file is not evaluated(?) when importing the module. It is also not possible to use the importlib.resources files method to find the registry files from an editable-installed module. In an attempt to support ediable installs, for easier debugging of dependent modules, the version method is defined in a new file, version.py, which is imported and used to populate the module __version__ property. This method is then used in place of the dunder version throughout mccode_antlr. The importlib.metadata module has a distribution method which can be used to identify editable installs of modules. This is used in a bit of a hack to locate registry files in case the importlib.resources method fails. Unfortunatley, the auto-generation of the grammar files does not work for editable installs; so the whole machinery still fails. These files *should* be static in the distributed module -- so that the dependency on antlr can be reduced to just the runtime. But since this is not entirely trivial to change, editable installations will continue to not work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16 by correcting bug in generated component
_{name}_setposfunctions.A recent change inadvertently used the component rotation angles in place of its position vector components.
This fixes that error and refactors extraction of the components and reference slightly to minimize the chance of a similar problem happening again.
Additionally, the compiled test instrument output data files are now loaded and checked to contain intensity.
This necessitated addition a dat file loader for point-like detectors.