Fix problems identified in McStas example instrument tests #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10]' as array instead of scalar
In order to insert DECLARE variables into the component-type parameters
struct, we need to be able to identify their type information.
These types _could_ be user-defined `typedef` aliases, provided in,
e.g., the SHARE section of the current or any-other component (probably
preceding only, but possibly trailing definitions, since SHARE goes
before all initialization).
Previously parsing for both variable declaration and typedefs was
performed in one pass, but this led to a confusing Listener class which
mistakenly identified typenames for `typedef` `struct`s incorrectly,
sometimes.
E.g.,
```
typdef struct the_struct_label {
double a_double;
int an_int;
} the_struct_alias;
```
would have been misidentified as the equivalent of
`typedef struct the_struct_label an_int;`
By splitting `typedef` and declaration parsing into two passes, there
are now two slightly-simpler Listener classes that handle the above case
plus all others implemented in a new test file.
This double-pass invariably means slower parsing, but this seems a
worthwhile trade-off at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to
WHEN, using more-correct C99 grammar, parsing of types forDECLAREblocks.