[Fix] LocalRegistry known/fullname glob inconsistency #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Reader
asks eachRegistry
in turn if it 'knows' a filename. If it does, thatRegistry
is then used to retrieve the file 'fullname', 'path', or contents. In the case ofLocalRegistry
the component is searched for in a more-restrictive way for the three latter cases, allowing for the possibility that aLocalRegistry
'knows' it has a file but can't find it.This makes the later checks less stringent, fixing #79, which could have the effect of allowing multiple matches for a file, especially if two copies of the same file (with modifications, presumably) exist in the same directory tree.
For now, this possible drawback is not blocking, since if there is a directory structure like
outside of the runtime directory, then one could specify
-I /ComponentA
or-I /backup/ComponentA
(instead of-I /
) to get just one copy of the same-named file in theLocalRegistry
.And a similar layout under the runtime directory would require moving or renaming of files.