Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise grain finding #104

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    43e7568 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc04a5c View commit details
    Browse the repository at this point in the history
  3. Use numba in hrdic flood fill

    jni committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9a0664c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Copy buffer after flood fill to avoid overwriting

    Using a NumPy array as a buffer increases performance, but leaves you
    open to bugs due to reusing the same buffer and overwriting it, which is
    what was happening. 😅
    
    There's a better-performing fix still: use a buffer as big as the image,
    but advance the start index in the buffer as you finish each flood fill.
    This guarantees optimal space and time requirements (no need for copies,
    or a huge buffer that is mostly unused).
    jni committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a3e9882 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8fc4f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    482017c View commit details
    Browse the repository at this point in the history
  2. Change grain.data.point to an array

    Update tests to pass
    mikesmic committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dfd2998 View commit details
    Browse the repository at this point in the history
  3. Fix test

    mikesmic committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a93cc74 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    8e91675 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8663497 View commit details
    Browse the repository at this point in the history
  3. Require python >= 3.8

    required for scipy >=1.9
    mikesmic committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    24ffb28 View commit details
    Browse the repository at this point in the history
  4. Remove py 3.12

    mikesmic committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d656cc8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1e586b1 View commit details
    Browse the repository at this point in the history