-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise grain finding #104
Merged
Merged
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 43e7568 - Browse repository at this point
Copy the full SHA 43e7568View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc04a5c - Browse repository at this point
Copy the full SHA bc04a5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a0664c - Browse repository at this point
Copy the full SHA 9a0664cView commit details
Commits on Oct 31, 2023
-
Copy buffer after flood fill to avoid overwriting
Using a NumPy array as a buffer increases performance, but leaves you open to bugs due to reusing the same buffer and overwriting it, which is what was happening. 😅 There's a better-performing fix still: use a buffer as big as the image, but advance the start index in the buffer as you finish each flood fill. This guarantees optimal space and time requirements (no need for copies, or a huge buffer that is mostly unused).
Configuration menu - View commit details
-
Copy full SHA for a3e9882 - Browse repository at this point
Copy the full SHA a3e9882View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8fc4f3 - Browse repository at this point
Copy the full SHA f8fc4f3View commit details
Commits on Nov 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 482017c - Browse repository at this point
Copy the full SHA 482017cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfd2998 - Browse repository at this point
Copy the full SHA dfd2998View commit details -
Configuration menu - View commit details
-
Copy full SHA for a93cc74 - Browse repository at this point
Copy the full SHA a93cc74View commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8e91675 - Browse repository at this point
Copy the full SHA 8e91675View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8663497 - Browse repository at this point
Copy the full SHA 8663497View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24ffb28 - Browse repository at this point
Copy the full SHA 24ffb28View commit details -
Configuration menu - View commit details
-
Copy full SHA for d656cc8 - Browse repository at this point
Copy the full SHA d656cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e586b1 - Browse repository at this point
Copy the full SHA 1e586b1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.