Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prefer movie.nfo when reading/writing nfo files #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

randellhodges
Copy link

@randellhodges randellhodges commented May 4, 2024

Many years ago, I asked for an option to always use the movie.nfo file instead of the <movie_name>.nfo, both when reading and saving the nfo files. I had something hacked together that I was using, but thought it might be time to try and get something official.

This change adds an option to "Prefer movie.nfo", which, by default is off, so it maintains original behavior.

I pulled some stuff into the helper class and attempted to reuse the same method when finding and saving the nfo files. I also added a Test project just to sanity check some changes. It was really only designed to run on windows/net8, but the purpose of the test project isn't to test all the stuff like IFileSystem or any of the core Emby stuff, just to validate the single helper function I created.

@randellhodges randellhodges changed the title Add option to prefer movie.nfo when reading/writing nfo files. Also a… Add option to prefer movie.nfo when reading/writing nfo files May 4, 2024
@randellhodges
Copy link
Author

I was considering changing MovieInfoSaver.GetSavePath to work a bit like BaseInfoVideoProvider.GetXmlFile, where, it would try to save back to the same file and only use the first candidate if there were no nfo files that already exist.

@randellhodges randellhodges marked this pull request as ready for review May 20, 2024 23:57
@randellhodges randellhodges force-pushed the PreferMovieNfo branch 2 times, most recently from 3aa9902 to 770a1a4 Compare September 28, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant