Skip to content

Commit

Permalink
Merge pull request #297 from MediaPortal/MP1-5213-Fix_occasional_Medi…
Browse files Browse the repository at this point in the history
…aPortal_crash_upon_stopping_playback_with_MPAudioRenderer

MP1-5213: MPAudioRenderer: Fix desctructor call to prevent MediaPorta…
  • Loading branch information
andrewjswan authored Apr 1, 2024
2 parents ae761f6 + 7a1a477 commit 39a0cfd
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions DirectShowFilters/MPAudioRenderer/source/MpAudioRenderer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ CMPAudioRenderer::~CMPAudioRenderer()
if (m_pVolumeHandler)
m_pVolumeHandler->Release();

delete m_pClock;

if (m_pReferenceClock)
{
SetSyncSource(NULL);
Expand All @@ -177,9 +175,7 @@ CMPAudioRenderer::~CMPAudioRenderer()
if (FAILED(hr))
Log("Pipeline DisconnectAll failed with: (0x%08x)", hr);
}

SAFE_RELEASE(m_pSettings);


delete m_pWASAPIRenderer;
delete m_pAC3Encoder;
delete m_pInBitDepthAdapter;
Expand All @@ -188,6 +184,9 @@ CMPAudioRenderer::~CMPAudioRenderer()
delete m_pSampleRateConverter;
delete m_pChannelMixer;
delete m_pSampleCopier;
delete m_pClock;

SAFE_RELEASE(m_pSettings);

Log("MP Audio Renderer - destructor - instance 0x%x - end", this);
if (m_pLogger)
Expand Down

0 comments on commit 39a0cfd

Please sign in to comment.