Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto git provider #38

Closed
wants to merge 2 commits into from
Closed

Refacto git provider #38

wants to merge 2 commits into from

Conversation

vincentli77
Copy link
Collaborator

No description provided.

import { FileSystemManager } from '../utils/fileSystem.utils'

export abstract class AbstractGit {
protected fileSystem = new FileSystemManager()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En typescript on défini pas de class abstract comme en JS ou en Java car on a déjà les interfaces pour ça donc cette class est pas du tout abstract surtout qu'elle embarque de la logique

this.type === 'github'
? /https:\/\/github\.com\/([^/]+)\/([^/]+)/
: /https:\/\/gitlab\.com\/([^/]+)\/([^/]+)/
const match = this.repository.match(regex)!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le problème de cette fonction c'est qu'elle respecte pas le principe solid 'one responsability'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants