WIP: ArmSystemReady Interim Solution for UEFI vars using UEFI Global Variables #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Var GUID DO NOT MERGEE THIS CHANGE!!! UEFI spec states: "UEFI Drivers must never use EFIGLOBAL_VARIBLE GUID or gEfiGlobalVariableGuid to store configuration information. This GUID is reserved for use by the UEFI Specification." These changes relate to BfsbStatus, RshimMacAddr, OobMacAddr which all use the EFI Global Guid. "BfsbStatus" changes in "bfsbdump" - tested these on current 4.x and a 4.x with none of the UEFI modifications and verified scrupt used the correct GUID. For "RshimMacAddr" verified the new GUID was used and similar to above, the Global Guid was used if a 4.x without UEFI changes. For "OobMacAddr", I manually changed "bfcfg" to force creation of the gMlxBfCfgGuid" in the system efi vars> To fully test this, would need to be manufacturing configuring an OobMacAddr on a new board (I believe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Var GUID
DO NOT MERGE THIS CHANGE!!!
UEFI spec states:
"UEFI Drivers must never use EFIGLOBAL_VARIBLE GUID or gEfiGlobalVariableGuid to store configuration information. This GUID is reserved for use by the UEFI Specification."
These changes relate to BfsbStatus, RshimMacAddr, OobMacAddr which all use the EFI Global Guid.
"BfsbStatus" changes in "bfsbdump" - tested these on current 4.x and a 4.x with none of the UEFI modifications and verified script used the correct GUID.
For "RshimMacAddr" verified the new GUID was used and similar to above, the Global Guid was used if a
4.x without UEFI changes.
For "OobMacAddr", I manually changed "bfcfg" to force creation of the gMlxBfCfgGuid" in the systems efi variables.
ls -l /sys/firmware/efi/efivars
To fully test this, would need to be manufacturing configuring an OobMacAddr on a new board (I believe)
RM #3431862