Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfpxe: Improve MAC address parsing #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pawel-baldysiak-dell
Copy link

Currently "bfmac=" param expects MAC address to follow "aa-bb-cc-dd-ee-ff" format, however standard defines that it might also be "aa:bb:cc:dd:ee:ff".
Change the way how "bfmac=" param is parsed, so it accepts both formats.

Currently "bfmac=" param expects MAC address to follow
"aa-bb-cc-dd-ee-ff" format, however standard defines that
it might also be "aa:bb:cc:dd:ee:ff".
Change the way how "bfmac=" param is parsed, so it accepts
both formats.

Signed-off-by: Pawel Baldysiak <[email protected]>
Copy link
Collaborator

@mahantesh-nvidia mahantesh-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is backward compatible and also handles grub format. This is efficient because the mac is required to be in the same format as grub stores is it, for finding the matching interface name from /sys/class/net/*/address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants