Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw-mgmt: scripts: Added hw-mgmt done WatchDog. #1298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bspguy
Copy link
Collaborator

@bspguy bspguy commented Jul 11, 2024

This PR adds a WD, for tracking symbolic link creation.

@sw-r2d2-bot
Copy link
Collaborator

Can one of the admins verify this patch?

#
source hw-management-helpers.sh

trace_udev_events "hw-mngmt done called"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is meant for udev events tracing only. Use log_info() instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

current_time=$(date +%s%3N)

# Read the last reset time atomically.
if [[ -f "$WATCHDOG_RESET_FILE" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the name from watchdog to something like monitor, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadimp-nvidia @ciju-nvidia What is your decision?
wd/monitor?

# Update the status file.
echo "1" > "$WATCHDOG_STATUS_FILE"
# Update syslog.
logger "hw-management script done!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use log_info()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bspguy bspguy force-pushed the hw-mgmt-watchdog branch from aa14170 to 437ed26 Compare July 12, 2024 18:53
@bspguy bspguy force-pushed the hw-mgmt-watchdog branch 4 times, most recently from aa30ff4 to 12a87b1 Compare August 25, 2024 14:02
@bspguy bspguy force-pushed the hw-mgmt-watchdog branch 2 times, most recently from 7842bdf to 2925a60 Compare September 23, 2024 09:07
@bspguy bspguy self-assigned this Sep 26, 2024
@bspguy bspguy requested a review from ciju-nvidia September 26, 2024 13:03
@bspguy bspguy enabled auto-merge (rebase) September 26, 2024 13:09
@bspguy bspguy requested review from mshych and removed request for mshych and yyehudai September 26, 2024 13:41
@bspguy
Copy link
Collaborator Author

bspguy commented Sep 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants