Skip to content

Commit

Permalink
issue: 3586273 Use XLIO_DEFERRED_CLOSE by default
Browse files Browse the repository at this point in the history
For incoming sockets - no change.
For outgoing sockets - since outgoing sockets occupy a local port, we
should release it on the socket destructor to prevent race from another
socket to use the same port.
This race might cause XLIO to hold 2 sockets with the same RFS object at
the same time, and this is fatal (particularly for TCP).

Signed-off-by: Iftah Levi <[email protected]>
  • Loading branch information
iftahl committed Apr 14, 2024
1 parent 1e18c6a commit fc87b73
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/util/sys_vars.h
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ extern mce_sys_var &safe_mce_sys();
#endif /* DEFINED_UTLS */

#define MCE_DEFAULT_LRO (option_3::AUTO)
#define MCE_DEFAULT_DEFERRED_CLOSE (false)
#define MCE_DEFAULT_DEFERRED_CLOSE (true)
#define MCE_DEFAULT_TCP_ABORT_ON_CLOSE (false)
#define MCE_DEFAULT_RX_POLL_ON_TX_TCP (false)
#define MCE_DEFAULT_TRIGGER_DUMMY_SEND_GETSOCKNAME (false)
Expand Down

0 comments on commit fc87b73

Please sign in to comment.