issue: 3586273 Use XLIO_DEFERRED_CLOSE by default

.ci/artifacts.sh

@@ -1,12 +1,9 @@
 #!/bin/bash -xl
 
 if [ -d jenkins ]; then
-    gzip -f ./jenkins/*.tar 2>/dev/null || true
-    cd ./jenkins/ ;
-        for f in *.tar.gz ; do [ -e "$f" ] && mv "$f" "${flags}/arch-${name}-$f" ; done ;
-    cd ..
-    cd ./jenkins/${flags};
-        for f in *.tap ; do [ -e "$f" ] && mv "$f" "${flags}-${name}-$f" ; done ;
-        for f in *.xml ; do [ -e "$f" ] && mv "$f" "${flags}-${name}-$f" ; done ;
-    cd ../..
+    pushd ./jenkins/${flags};
+    gzip -f *.tar 2>/dev/null || true
+    for f in *.tar.gz ; do mv -f "$f"  "arch-${name}-$f" ; done;
+    for f in *.{tap,xml} ; do mv -f "$f" "${flags}-${name}-$f" ; done ;
+    popd
 fi

.ci/dockerfiles/Dockerfile.rhel8.6

@@ -0,0 +1,26 @@
+FROM harbor.mellanox.com/hpcx/x86_64/rhel8.6/core:latest
+ARG _UID=6213
+ARG _GID=101
+ARG _LOGIN=swx-jenkins
+ARG _HOME=/var/home/$_LOGIN
+
+RUN yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm \
+ && yum install -y cppcheck \
+ && yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm \
+ && yum install -y csbuild clang-tools-extra sudo curl autoconf automake make libtool \
+    libnl3-devel libnl3 rdma-core-devel rdma-core bc \
+ && yum clean all
+
+RUN pip3 install -U pip --no-cache-dir \
+ && pip3 install compiledb --no-cache-dir
+
+RUN echo "${_LOGIN} ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers && \
+    echo "root ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers && \
+    mkdir -p ${_HOME} && \
+    groupadd -f -g "$_GID" "$_LOGIN" && \
+    useradd -u "$_UID" -g "$_GID" -s /bin/bash -m -d ${_HOME} "${_LOGIN}" && \
+    chown -R ${_LOGIN} ${_HOME} && \
+    mkdir /build && chown -R ${_LOGIN} /build
+
+USER "$_LOGIN"
+ENTRYPOINT [ "/bin/bash", "--login", "--rcfile", "/etc/bashrc", "-c" ]

.ci/matrix_job.yaml

@@ -4,16 +4,20 @@ job: LIBXLIO
 step_allow_single_selector: false
 
 registry_host: harbor.mellanox.com
-registry_auth: swx-storage
+registry_auth: 1daaea28-800e-425f-a91f-3bd3e9136eea
+registry_path: /swx-infra/media
 
 kubernetes:
   privileged: false
   cloud: swx-k8s-spray
   nodeSelector: 'beta.kubernetes.io/os=linux'
-
+  namespace: xlio-ci
   limits: '{memory: 8Gi, cpu: 7000m}'
   requests: '{memory: 8Gi, cpu: 7000m}'
 
+credentials:
+  - {credentialsId: '925b0900-e273-4042-bc7c-facaefae0727', usernameVariable: 'XLIO_COV_USER', passwordVariable: 'XLIO_COV_PASSWORD'}
+
 volumes:
   - {mountPath: /hpc/local/bin, hostPath: /hpc/local/bin}
   - {mountPath: /hpc/local/oss, hostPath: /hpc/local/oss}
@@ -29,9 +33,6 @@ volumes:
   # User profile for release
   - {mountPath: /var/home/swx-jenkins, hostPath: /labhome/swx-jenkins}
 
-env:
-  build_dockers: false
-
 runs_on_dockers:
 # mofed
   - {name: 'ub20.04-mofed-x86_64', url: 'harbor.mellanox.com/swx-infra/x86_64/ubuntu20.04/builder:mofed-5.2-2.2.0.0', category: 'base', arch: 'x86_64'}
@@ -40,9 +41,34 @@ runs_on_dockers:
   - {name: 'rhel8.6-mofed-x86_64',  url: 'harbor.mellanox.com/hpcx/x86_64/rhel8.6/builder:mofed-5.6-0.4.5.0', category: 'base', arch: 'x86_64'}
 #  - {name: 'oracle8.6-mofed-x86_64',  url: 'harbor.mellanox.com/rivermax/base_oraclelinux8.6:mofed-5.9-0.3.4.0', category: 'base', arch: 'x86_64'}
 # tool
-  - {name: 'toolbox', url: 'harbor.mellanox.com/hpcx/x86_64/rhel8.3/builder:inbox', category: 'tool', arch: 'x86_64'}
+  - {name: 'toolbox', url: 'harbor.mellanox.com/hpcx/x86_64/rhel8.6/builder:inbox', category: 'tool', arch: 'x86_64'}
   - {name: 'blackduck', url: 'harbor.mellanox.com/toolbox/ngci-centos:7.9.2009.2', category: 'tool', arch: 'x86_64'}
   - {name: 'header-check', url: 'harbor.mellanox.com/toolbox/header_check:0.0.14', category: 'tool', arch: 'x86_64', tag: '0.0.14'}
+# static tests
+  - {file: '.ci/dockerfiles/Dockerfile.rhel8.6',
+     arch: 'x86_64',
+     name: 'xlio_static.cppcheck',
+     uri: '$arch/$name',
+     tag: '20240703',
+     build_args: '--no-cache',
+     category: 'tool'
+     }
+  - {file: '.ci/dockerfiles/Dockerfile.rhel8.6',
+     arch: 'x86_64',
+     name: 'xlio_static.csbuild',
+     uri: '$arch/$name',
+     tag: '20240703',
+     build_args: '--no-cache',
+     category: 'tool'
+     }
+  - {file: '.ci/dockerfiles/Dockerfile.rhel8.6',
+     arch: 'x86_64',
+     name: 'xlio_static.tidy',
+     uri: '$arch/$name',
+     tag: '20240703',
+     build_args: '--no-cache',
+     category: 'tool'
+     }
 
 runs_on_agents:
   - {nodeLabel: 'beni09', category: 'base'}
@@ -51,7 +77,6 @@ matrix:
   axes:
     flags:
       - default
-      - dpcp
     arch:
       - x86_64
       - aarch64
@@ -196,6 +221,7 @@ steps:
 
   - name: Coverity
     enable: ${do_coverity}
+    credentialsId: '925b0900-e273-4042-bc7c-facaefae0727'
     containerSelector:
       - "{name: 'toolbox', category: 'tool'}"
     agentSelector:
@@ -215,9 +241,9 @@ steps:
   - name: Cppcheck
     enable: ${do_cppcheck}
     containerSelector:
-      - "{name: 'skip-container'}"
+      - "{name: 'xlio_static.cppcheck', category: 'tool', variant: 1}"
     agentSelector:
-      - "{nodeLabel: 'beni09', variant:2}"
+      - "{nodeLabel: 'skip-agent'}"
     run: |
       [ "x${do_cppcheck}" == "xtrue" ] && action=yes || action=no
       env WORKSPACE=$PWD TARGET=${flags} jenkins_test_cppcheck=${action} ./contrib/test_jenkins.sh
@@ -232,9 +258,9 @@ steps:
   - name: Csbuild
     enable: ${do_csbuild}
     containerSelector:
-      - "{name: 'skip-container'}"
+      - "{name: 'xlio_static.csbuild', category: 'tool', variant: 1}"
     agentSelector:
-      - "{nodeLabel: 'beni09', variant:2}"
+      - "{nodeLabel: 'skip-agent'}"
     run: |
       [ "x${do_csbuild}" == "xtrue" ] && action=yes || action=no
       env WORKSPACE=$PWD TARGET=${flags} jenkins_test_csbuild=${action} ./contrib/test_jenkins.sh
@@ -249,9 +275,9 @@ steps:
   - name: Tidy
     enable: ${do_tidy}
     containerSelector:
-      - "{name: 'skip-container'}"
+      - "{name: 'xlio_static.tidy', category: 'tool', variant: 1}"
     agentSelector:
-      - "{nodeLabel: 'beni09', variant:2}"
+      - "{nodeLabel: 'skip-agent'}"
     run: |
       [ "x${do_tidy}" == "xtrue" ] && action=yes || action=no
       env WORKSPACE=$PWD TARGET=${flags} jenkins_test_tidy=${action} ./contrib/test_jenkins.sh
@@ -268,7 +294,7 @@ steps:
     containerSelector:
       - "{name: 'skip-container'}"
     agentSelector:
-      - "{nodeLabel: 'beni09', variant:2}"
+      - "{nodeLabel: 'beni09'}"
     run: |
       [ "x${do_test}" == "xtrue" ] && action=yes || action=no
       env WORKSPACE=$PWD TARGET=${flags} jenkins_test_run=${action} ./contrib/test_jenkins.sh

.ci/opensource_jjb.yaml

@@ -74,6 +74,10 @@
             name: "do_coverity"
             default: true
             description: "Launch coverity verification."
+        - bool:
+            name: "do_coverity_snapshot"
+            default: false
+            description: "Submit Coverity Static Analysis as a snapshot (normally it should be checked only for master branch after proper defects review)"
         - bool:
             name: "do_test"
             default: true

CHANGES

@@ -1,3 +1,65 @@
+Version 3.30.5-1:
+Date + Time 2024-0-09
+=============================================================
+Fixed:
+        - RM #3795997 OCI degradation IO operations with 8k conn, block size of 256k
+        - RM #3855390 http CPS test with IPv6 is reporting XLIO warning
+        - RM #3788164 Nginx Degradation 10MB with a low number of workers.
+
+Version 3.30.4-1:
+Date + Time 2024-04-04
+=============================================================
+Fixed:
+        - RM #3792798 Do code cleanup for new storage API
+        - RM #3829626 Nginx http CPS tests report error
+        - RM #3818038 I/O errors during FIO
+
+Version 3.30.3-1:
+Date + Time 2024-03-20
+=============================================================
+Added:
+        - RM #3788369 New Storage API
+        - RM #3777348 Improve sockinfo cache utilization
+
+Fixed:
+        - RM #3829626 Nginx http CPS tests report XLIO ERROR
+        - RM #3808935 SNAP4 static build error
+
+Version 3.30.2-1:
+Date + Time 2024-03-11
+=============================================================
+Added:
+        - RM #3792777 provide new storage API headers
+        - RM #3792789 provide new storage API implementation, integration level
+        - RM #3770816 Modernize C++ source code
+        - RM #3813802 Fix warnings from newer cppcheck version
+        - RM #3795922 Remove pbuf_split_64k() and refused_data
+
+Fixed:
+        - RM #3781322 higher CPU loads when loaded with Nginx responding to http requests of high payloads.
+        - RM #3792731 False positive Walloc-size-larger-than warning
+
+Version 3.30.1-1:
+Date + Time 2024-02-22
+=============================================================
+Fixed:
+        - RM #3786434 C++ or C23 feature in xlio_extra.h breaks compilation of some C programs
+
+Version 3.30.0-1:
+Date + Time 2024-02-12
+=============================================================
+Added:
+        - RM #3724170 Static compilation with LTO and PGO support
+        - RM #3668182 productize LwIP express data path
+        - RM #3664594 Backport TCP_KEEPALIVE from VMA
+        - RM #3514044 XLIO DPCP Only - Remove legacy code and legacy flows
+
+Fixed:
+        - RM #3771283 Fix function pointer check
+        - RM #3690535 Remove leftover after Multi Packet RQ removal
+        - RM #3678579 Fix last_unacked and last_unsent
+        - RM #3704820 XLIO error when enabling UDP listen socket
+
 Version 3.21.2-1:
 Date + Time 2024-01-11
 =============================================================

README

@@ -153,6 +153,7 @@ Example:
  XLIO DETAILS: Mem Allocation type            Huge pages                 [XLIO_MEM_ALLOC_TYPE]
  XLIO DETAILS: Memory limit                   2 GB                       [XLIO_MEMORY_LIMIT]
  XLIO DETAILS: Memory limit (user allocator)  0                          [XLIO_MEMORY_LIMIT_USER]
+ XLIO DETAILS: Hugepage size                  0                          [XLIO_HUGEPAGE_SIZE]
  XLIO DETAILS: Num of UC ARPs                 3                          [XLIO_NEIGH_UC_ARP_QUATA]
  XLIO DETAILS: UC ARP delay (msec)            10000                      [XLIO_NEIGH_UC_ARP_DELAY_MSEC]
  XLIO DETAILS: Num of neigh restart retries   1                          [XLIO_NEIGH_NUM_ERR_RETRIES]
@@ -963,6 +964,12 @@ provided with XLIO extra API. Default value 0 makes XLIO use XLIO_MEMORY_LIMIT
 value for user allocations.
 Default value is 0
 
+XLIO_HUGEPAGE_SIZE
+Force specific hugepage size for XLIO internal memory allocations. Value 0 allows
+to use any supported and available hugepages. The size may be specified with
+suffixes such as KB, MB, GB.
+Default value is 0
+
 XLIO_NEIGH_UC_ARP_QUATA
 XLIO will send UC ARP in case neigh state is NUD_STALE.
 In case that neigh state is still NUD_STALE XLIO will try

README.md

@@ -64,17 +64,6 @@ $ make -j
 $ make install
 ```
 
-### Building XLIO without dpcp
-
-```sh
-$ ./autogen.sh
-$ ./configure --prefix=/where/to/install
-$ make -j
-$ make install
-```
-
-Advanced HW features are not enabled for this build type.
-
 ### Usage Examples
 
 #### Sockperf