issue: 3759513 Fix blocking SSL_sendfile() #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (m_p_zc_owner) { | ||
| /* | ||
| * For zerocopy case we create 3 scatter-gather elements in this order: | ||
| * [0] TLS header which includes IV for TLS 1.2 | ||
| * [1] Payload | ||
| * [2] Trailer which contains TAG and TLS 1.3 type if applicable | ||
| */ | ||
| assert(iov_max >= 3); | ||
| (void)iov_max; | ||
| tx_attr.attr.sz_iov = 3; |
There was a problem hiding this comment.
Should we use TLS_IOV_SIZE here?
and in the static_assert above
| @@ -186,6 +186,8 @@ enum : size_t { | |||
| TLS_RECORD_MAX = 16384U, | |||
| /* Block size big enough to hold TLS header/trailer for zerocopy records. */ | |||
| TLS_ZC_BLOCK = 32U, | |||
| /* Maximum number of scatter-gather elements for TCP send operation. */ | |||
There was a problem hiding this comment.
Please add to the comment why 3 ...
|
Last check introduces some degradation that should be investigated |
AlexanderGrissik
force-pushed
the
vNext
branch
from
cfce2e8 to
51c2340
Compare
SSL_sendfile() creates 3 iov elements, however, for a blocking socket only a signle element is expected in partial write handling. Signed-off-by: Dmytro Podgornyi <[email protected]>
pasis
force-pushed
the
ssl-sendfile-blocking
branch
from
17d49f8 to
4584e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSL_sendfile() creates 3 iov elements, however, for a blocking socket only a signle element is expected in partial write handling.
What
Fix partial write handling in blocking TLS offload path.
Why ?
Blocking SSL_sendfile() fix.
Change type
What kind of change does this PR introduce?
Check list