Sys ctl to env param #277
Sys ctl to env param #277
Conversation
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
from
42593aa to
765614a
Compare
Refactored the logic to retrieve system parameters via environment variables instead of relying on system control (`sysctl`) parameters. Improved compatibility with containerized and runtime-configurable environments. Signed-off-by: Bashar Abdelgafer <[email protected]>
Changed TSO and LRO defaults ON instead of auto for simplified configuration. Signed-off-by: Bashar Abdelgafer <[email protected]>
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
from
765614a to
5da4add
Compare
|
bot:retest |
1 similar comment
|
bot:retest |
|
After discussion with Igor, we need to consider control parameters. Such as bindipv6only. These parameters are better to set the same as Kernel as these affect app behavior rather than performance. Lets discuss how we should proceed with them. |
| @@ -904,6 +935,35 @@ extern mce_sys_var &safe_mce_sys(); | |||
| #define STRQ_MIN_STRIDE_SIZE_BYTES 64 | |||
| #define STRQ_MAX_STRIDE_SIZE_BYTES 8192 | |||
|
|
|||
| /* Sysctl configurations*/ | |||
| #define MCE_DEFAULT_TCP_MAX_SYN_BACKLOG 4096 | |||
There was a problem hiding this comment.
would increase MCE_DEFAULT_TCP_MAX_SYN_BACKLOG to 50000
| #define MCE_DEFAULT_TCP_WMEM_MAX 4194304 | ||
|
|
||
| #define MCE_DEFAULT_TCP_RMEM_MIN 4096 | ||
| #define MCE_DEFAULT_TCP_RMEM_DEFAULT 131072 |
There was a problem hiding this comment.
would increase MCE_DEFAULT_TCP_RMEM_DEFAULT to 16MB
|
|
||
| #define MCE_DEFAULT_TCP_RMEM_MIN 4096 | ||
| #define MCE_DEFAULT_TCP_RMEM_DEFAULT 131072 | ||
| #define MCE_DEFAULT_TCP_RMEM_MAX 6291456 |
There was a problem hiding this comment.
would increase MCE_DEFAULT_TCP_RMEM_MAX to 16MB
|
|
||
| #define MCE_DEFAULT_TCP_WINDOW_SCALING 1 | ||
| #define MCE_DEFAULT_NET_CORE_RMEM_MAX 16777216 | ||
| #define MCE_DEFAULT_NET_CORE_WMEM_MAX 212992 |
There was a problem hiding this comment.
would increase MCE_DEFAULT_NET_CORE_WMEM_MAX to 16MB
| #define MCE_DEFAULT_TCP_MAX_SYN_BACKLOG 4096 | ||
| #define MCE_DEFAULT_LISTEN_MAXCONN 4096 | ||
|
|
||
| #define MCE_DEFAULT_TCP_WMEM_MIN 4096 |
There was a problem hiding this comment.
I see all these are unused in practice. so all this stuff and related code in xlio can be removed.
There was a problem hiding this comment.
all MCE_DEFAULT_TCP_WMEM_x
Description
Read system control parameters from environment variables
Configure TSO and LRO default to ON
What
Subject: what this PR is doing in one line.
Why ?
better control of sys vars in virtual and container environment
How ?
read from enviorn variables instead of sys ctl
Change type
What kind of change does this PR introduce?
Check list