Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport a pre-delete helm hook for sriov-network-operator #1013

Closed

Conversation

almaslennikov
Copy link
Collaborator

Mutating and Validating webhook configs are created programmatically and are not managed by helm.
To clean them up on helm delete, adding a small pre-delete hook
Backport of: k8snetworkplumbingwg/sriov-network-operator#751

Mutating and Validating webhook configs are created programmatically
and are not managed by helm.
To clean them up on helm delete, adding a small pre-delete hook
k8snetworkplumbingwg/sriov-network-operator#751

Signed-off-by: amaslennikov <[email protected]>
@almaslennikov almaslennikov changed the title Backport a pre-delete helm hook for sriov-network-operator chore: backport a pre-delete helm hook for sriov-network-operator Jul 29, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10144483051

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.977%

Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 2 79.5%
controllers/hostdevicenetwork_controller.go 2 89.77%
controllers/macvlannetwork_controller.go 2 86.25%
Totals Coverage Status
Change from base Build 10135311110: 0.2%
Covered Lines: 3308
Relevant Lines: 5091

💛 - Coveralls

- /bin/sh
- -c
- |
kubectl delete MutatingWebhookConfiguration -n {{ .Release.Namespace }} sriov-operator-webhook-config network-resources-injector-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if these CRs are not available? Will the Job fail?
Do we need ; at the end?
Maybe add || true;

@almaslennikov almaslennikov marked this pull request as draft August 29, 2024 07:20
@rollandf
Copy link
Member

I think we can close this one.
Covered in k8snetworkplumbingwg/sriov-network-operator#791

@rollandf rollandf closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants