Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: bump network-resources-injector version to support multi-arch #1247

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

heyvister1
Copy link
Collaborator

@heyvister1 heyvister1 commented Jan 8, 2025

Previous version didn't support multi-arch

Screenshot 2025-01-09 at 14 57 09

@heyvister1 heyvister1 requested review from e0ne and rollandf January 8, 2025 14:41
@coveralls
Copy link
Collaborator

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12690328005

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 60.323%

Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
controllers/nicclusterpolicy_controller.go 3 79.08%
Totals Coverage Status
Change from base Build 12685638732: 0.04%
Covered Lines: 3325
Relevant Lines: 5512

💛 - Coveralls

rollandf
rollandf previously approved these changes Jan 8, 2025
@heyvister1 heyvister1 added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 8, 2025
@heyvister1 heyvister1 removed the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 9, 2025
@heyvister1 heyvister1 merged commit 74690cd into Mellanox:master Jan 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants