Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure container resources in the helm chart #717

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

almaslennikov
Copy link
Collaborator

Update README
Add continuity check unit test:

  • This test renders all manifests to extract deployable containers' names and parses values.yaml from the helm chart to make sure that all containers are represented in the helm chart under the ResourceRequirements section

@almaslennikov almaslennikov changed the title Configure container resources in the helm chart feat: Configure container resources in the helm chart Dec 20, 2023
@almaslennikov almaslennikov force-pushed the helm-container-resources branch 3 times, most recently from dc58f82 to 22471e1 Compare December 20, 2023 11:26
@almaslennikov almaslennikov force-pushed the helm-container-resources branch from 22471e1 to 8bb7167 Compare December 20, 2023 15:50
Copy link
Member

@rollandf rollandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
Need rebase after other PR is merged

@almaslennikov almaslennikov force-pushed the helm-container-resources branch from 8bb7167 to eb05f1a Compare December 20, 2023 16:00
@almaslennikov almaslennikov force-pushed the helm-container-resources branch from eb05f1a to d1cf0e4 Compare December 22, 2023 10:28
This test renders all manifests to extract deployable containers' names
and parses values.yaml from the helm chart to make sure that all
containers are represented in the helm chart
under the ResourceRequirements section

Signed-off-by: amaslennikov <[email protected]>
@almaslennikov almaslennikov force-pushed the helm-container-resources branch from d1cf0e4 to 32fb272 Compare December 22, 2023 10:29
@almaslennikov almaslennikov merged commit 2ed73d1 into Mellanox:master Dec 22, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants