Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ForcePrecompiled flag #727

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

rollandf
Copy link
Member

@rollandf rollandf commented Jan 1, 2024

Mofed images support some OS/Kernel with precompiled
drivers.

In case that a Precompiled image is available in the image registry,
it will be used for MOFED, otherwise the image with sources will be
used.

The user can specify that in case the precompiled image does not exists,
the Ofed State will fail.
This can be done with setting ForcePrecompiled to "true" in "ofedDriver"
spec in NicClusterPolicy.

The default for ForcePrecompiled is false.

@rollandf rollandf added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 1, 2024
@rollandf
Copy link
Member Author

rollandf commented Jan 1, 2024

Depends on #691

@rollandf rollandf removed the on hold This enhancement is currently on hold pending additional clarification and evaluation label Mar 3, 2024
ykulazhenkov
ykulazhenkov previously approved these changes Mar 6, 2024
pkg/docadriverimages/doca_drivers.go Show resolved Hide resolved
@killianmuldoon
Copy link
Contributor

@rollandf can you rebase this one?

Mofed images support some OS/Kernel with precompiled
drivers.

In case that a Precompiled image is available in the image registry,
it will be used for MOFED, otherwise the image with sources will be
used.

The user can specify that in case the precompiled image does not exists,
the Ofed State will fail.
This can be done with setting ForcePrecompiled to "true" in "ofedDriver"
spec in NicClusterPolicy.

The default for ForcePrecompiled is false.

Signed-off-by: Fred Rolland <[email protected]>
@e0ne
Copy link
Collaborator

e0ne commented Mar 13, 2024

/retest-nic_operator_kind

1 similar comment
@rollandf
Copy link
Member Author

/retest-nic_operator_kind

@ykulazhenkov ykulazhenkov self-requested a review March 18, 2024 08:26
Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e0ne e0ne merged commit a160883 into Mellanox:master Mar 18, 2024
16 checks passed
@rollandf rollandf deleted the forceprecompiled branch August 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants