-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ForcePrecompiled flag #727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollandf
added
the
on hold
This enhancement is currently on hold pending additional clarification and evaluation
label
Jan 1, 2024
Depends on #691 |
rollandf
force-pushed
the
forceprecompiled
branch
from
January 1, 2024 13:35
87927e9
to
db66b7f
Compare
rollandf
force-pushed
the
forceprecompiled
branch
from
March 3, 2024 14:17
db66b7f
to
f23b5a2
Compare
rollandf
removed
the
on hold
This enhancement is currently on hold pending additional clarification and evaluation
label
Mar 3, 2024
ykulazhenkov
previously approved these changes
Mar 6, 2024
ykulazhenkov
reviewed
Mar 7, 2024
@rollandf can you rebase this one? |
Mofed images support some OS/Kernel with precompiled drivers. In case that a Precompiled image is available in the image registry, it will be used for MOFED, otherwise the image with sources will be used. The user can specify that in case the precompiled image does not exists, the Ofed State will fail. This can be done with setting ForcePrecompiled to "true" in "ofedDriver" spec in NicClusterPolicy. The default for ForcePrecompiled is false. Signed-off-by: Fred Rolland <[email protected]>
rollandf
force-pushed
the
forceprecompiled
branch
from
March 13, 2024 12:52
f23b5a2
to
3cb012d
Compare
/retest-nic_operator_kind |
1 similar comment
/retest-nic_operator_kind |
ykulazhenkov
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e0ne
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mofed images support some OS/Kernel with precompiled
drivers.
In case that a Precompiled image is available in the image registry,
it will be used for MOFED, otherwise the image with sources will be
used.
The user can specify that in case the precompiled image does not exists,
the Ofed State will fail.
This can be done with setting ForcePrecompiled to "true" in "ofedDriver"
spec in NicClusterPolicy.
The default for ForcePrecompiled is false.