chore: Add missing tests for rendering manifests #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
pr-add-manifest-tests
branch
from
1906c76 to
5eba662
Compare
rollandf
reviewed
Feb 19, 2024
rollandf
reviewed
Feb 19, 2024
rollandf
reviewed
Feb 19, 2024
killianmuldoon
force-pushed
the
pr-add-manifest-tests
branch
2 times, most recently
from
5b32751 to
fc5e779
Compare
killianmuldoon
changed the title
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
pr-add-manifest-tests
branch
4 times, most recently
from
ee660f9 to
d33368e
Compare
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-add-manifest-tests
branch
from
d33368e to
1a2d3b7
Compare
killianmuldoon
commented
Feb 20, 2024
| } | ||
| } | ||
|
|
||
| func GetManifestObjectsTest(ctx context.Context, cr *mellanoxv1alpha1.NicClusterPolicy, catalog state.InfoCatalog, |
There was a problem hiding this comment.
I think we could expand this test to include more objects and checks. We'd then be able to run it on all Manifests for templating which is in common. Specific tests can then be run for fields which are different or novel between states.
There was a problem hiding this comment.
I like the idea. This function is already used in two files. Should we put it to common_test.go?
There was a problem hiding this comment.
+1, this can be done in a followup.
|
/retest-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
GetManifestObjectsfunctions across the board. The purpose of these tests is to ensure that each and every field can be rendered, and to prevent regressions from changes in the yamls.This PR includes #813 and should be held until that one merges.