-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump go to v1.21 #827
Conversation
I C that k8s repo contains 1.21 in the go.mod, but doesn't include the toolchain line. Do we want to keep it? Also we need to upgrade tools (see tests that failed) to be compatible with the toolchain setting. |
I think that as long as any dependency has a toolchain line we should stay at least equal to it. If we don't specify the toolchain it's implicitly v1.21.0 in this case anyway - so it's better to set it explicitly IMO. |
Let me take a look at the failures and try to fix them |
Signed-off-by: killianmuldoon <[email protected]>
5f639b4
to
636012f
Compare
The issue seems to be that most of our actions are just using whatever version of go is installed in the container - so it's not able to read go 1.21 module files. |
I've also removed the toolchaing directive now - but we're still implicitly at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chore: Bump go to v1.21
v1.21 is in use in the gomod and toolchain of some of our dependencies - at least controller runtime. Starting from Go 1.21 the go mod will be automatically updated to ensure we're working with the right toolchain.